Saman issues

Results 11 issues of


                                            Saman

Parsing from proto should keep field ID. (fixes #7645)

Fix issue #7645. When parsing from a proto that have explicit field identifiers, flatbuffers need to keep those identifiers stable by explicitly using the id attribute. This is because protos...

c++

codegen

Go generator undefined behavior

In cases that fbs file not defined namespace Go generator has undefined behavior, It generate file with blank package. plus not import files properly because their package name is empty....

Go code generator throw exception

In latest version of flatbuffer, built on windows, linux ubuntu 1804 and 22.04, with gcc-10 or clang-12 by running following command on its examples throw std bad_alloc exception in go...

Fix java import wild card

According to issue #7666 , we [emit wildcard imports for java](https://github.com/google/flatbuffers/blob/master/src/idl_gen_java.cpp#L181-L182), which are generally a bad idea and can trigger linters. We should be explicit in what we include and...

java

c++

codegen

Add clang-tidy, fix narrowing issues, fix constness

- introduce clang-tidy into codebase - rectify narrowing issues by adjusting type conversions appropriately to prevent potential data loss or undefined behavior - Review the codebase to identify areas where...

copybara-import

Enhancing Utility Functions in ops.h

I have tried to use highway library in the AddFrom, MulBy, MulByConst, MulByConstAndAdd, and create_distribution functions.

copybara-import

TODO (Optimize, potentially using new VQSort PartialSort)

I have a question about this TODO (**Optimize, potentially using new VQSort PartialSort**) in [here](https://github.com/google/gemma.cpp/blob/7e0a6fcab111c47bdea109a607edbd495ab198c1/ops.h#L734): I want to do it but I'm struggling to find a clean solution. Can you...

Feature

Saman