Endel Dreyer

Results 381 comments of Endel Dreyer

Glad you've worked it out @Zielak > So this `dynamicIndex` is going to keep increasing indefinitely. Can this become a concern in some cases, like: a constantly changing array in...

Hi @alexvargasbenamburg, would you mind elaborating more on what you mean? It is planned to generate `enum`'s during the `schema-codegen`. Interfaces have been implemented recently (https://github.com/colyseus/schema/pull/68). Besides `enum`, which other...

No worries, let's keep this issue open to track the progress of this :)

A quick note: to be able to support both `enum` of `int` and `string` values, I think it would be reasonable to convert enums to structs on C#: ```csharp struct...

Hi @amireldor, thanks for the PR! Interesting how you've approached the generated C# to feel more like a "native" enum. For simplicity's sake, though, I think would be better to...

Would it be possible to transform `shipType: ShipType` into `shipType: string` for C# in this case? 👀 Perhaps we'd need to relate these types in a similar way you've approached...

Hi @amireldor, sorry for the delay to reply here! > You don't mind losing type-safety here? If we use shipType: string, then we can assign ShipType.Transporter but also MyOtherStringEnum.SomeValue and...

Hi @ishnu47, we had a discussion about this in the [Discord server](https://discord.gg/RY8rRS7) after you posted this. @seiyria @Wenish and @Antriel were on this discussion. Here are some thoughts: - The...

Thanks for your input @ishnu47. Do you mind sharing the changes you've done in the C# handshake? I was reading how `flatbuffers` solves this and found this article: https://google.github.io/flatbuffers/md__schemas.html >...

I've had some progress with this today, the C# and JavaScript decoders are now backwards/forwards compatible by declaring new fields at the end of existing structures, and earlier declarations to...