Alex van Andel
Alex van Andel
Why is this mentioning in the description that it reverts 8041? It doesn't π
Ideally we'd let this error bubble up to the main error handler and handle there; not handling in the function itself; hope that makes sense π
Closing this in favour of https://github.com/calcom/cal.com/pull/9578 - but the underlying issue this could not be merged is still the same. Tests aren't passing @keithwillcode.
@VinoV1999 Thanks for your contribution; apologies for the delay we had some issues with the pipeline π
Closing this as it's possible that the parameter is an object - but the typescript is a little bit hard due to constructUri overloading.
@kaleem68 I committed in a potential fix for your consideration also
Hey @Amit91848 I wonder if there is a way to make this into a utility to prevent code duplication; also wondering if the check can be done before credential creation...
Picking this up further as it is related to some of my tasks.
I've checked each setting on the behaviour of the "Save" button - and no setting is blocked from saving so that's good enough for merge (as it's not the critical...
@jobenjada Hey man! Had a couple of run-throughs but it looks like this no longer happens π