cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Fix/timezone select

Open zomars opened this issue 2 years ago • 1 comments

What does this PR do?

  • Reverts #8041
  • Lazy loads TimeZoneSelect by default
  • Upgrades react-select to address website issue

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • [ ] Test website signup

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

zomars avatar May 04 '23 11:05 zomars

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ❌ Failed (Inspect) May 25, 2023 6:46pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2023 6:46pm

vercel[bot] avatar May 04 '23 11:05 vercel[bot]

Why is this mentioning in the description that it reverts 8041? It doesn't 😕

emrysal avatar May 10 '23 08:05 emrysal

whats missing here @zomars ? should we give this to gitstart or someone else?

PeerRich avatar May 25 '23 18:05 PeerRich

This PR is being closed due to inactivity. Please reopen if work is intended to be continued.

github-actions[bot] avatar Jul 06 '23 00:07 github-actions[bot]

Thank you for following the naming conventions! 🙏

github-actions[bot] avatar Jul 25 '23 18:07 github-actions[bot]