Lautaro Emanuel

Results 45 comments of Lautaro Emanuel

I've been thinking about how we could approach this issue. My idea is to add a rule to each language that splits single words so we can reuse the rules...

One quick note, the mentioned examples in the first comment aren't permalinks so I can't be sure to what they refer to. I understand that this issue is related to:...

@chessai Do you think that this could work?

Isn't this working as expected (returns an interval) in master? If so, should you close the issue @chessai?

The `morning` rule may be the cause of said values (`03:00` and `12:00`): https://github.com/facebook/duckling/blob/d8888e2ff842c4dacd570989570c101cf7b43153/Duckling/Time/DE/Rules.hs#L1339-L1350 *Shouldn't be `13` the upper bound, since it's non-inclusive?* It seems that the `morning` rule has...

**Update:** This issue is not exclusive to German, it also affects languages like English. For example, the input "morning from 9 to 12" returns the time span `00:00 to 01:00`....

**Update:** The same issue happens with Spanish. For example, the input "a la mañana de 9 a 13" returns the time span `04:00 to 12:00` which, again, are the bounds...

The same solution should apply to those 3 languages (I'm sure there are more affected by this bug): the "morning" / "part of day" rule **should not** have priority over...

@chessai I don't think that's the correct answer considering that the upper bound should be exclusive: we should get `09:00 - 13:00`. I think that the `12:00` that we get...

@talklittle How did you manage to get the patched code working on your project? Any chance I can reference your fork from Gradle?