Emilio Cobos Álvarez comments

Results 777 comments of


                                            Emilio Cobos Álvarez

fix some bitfield size calculate bug

Superseded by https://github.com/rust-lang/rust-bindgen/pull/3247. But feel free to comment there or send more patches if something is not addressed. Thanks!

conditional fields of constexpr literal structs

Sorry for the lag getting to this btw :(

conditional fields of constexpr literal structs

Could you rebase this please? Thanks!

conditional fields of constexpr literal structs

Thaks for the ping!

Incorrect equality operator generated with `derive_eq=true`

That C++ code just compares two chunks of uninitialized memory fwiw. My preference would be to fix this by generating `std::array` rather than plain arrays in C++ mode. But special-casing...

Incorrect equality operator generated with `derive_eq=true`

We don't generate `operator==` for C because C doesn't support operator overloading.

Remove UA styles for h1 in article, aside, nav, section

@domenic ping to get this merged? :)

Add support for std::mem::offset_of

This seems generally hard because we don't have compiler information. We could try to translate it to an `offsetof` in C / C++ perhaps tho?

[css-ui] Colors to use for appearance:base `<select>`

I'd prefer something like: ```css select { border: 1px solid ButtonBorder; background-color: Button; color: ButtonText; &:enabled:hover { background-color: ButtonHover; /* new */ color: ButtonHoverText; /* new */ } &:enabled:active {...

[css-ui] Colors to use for appearance:base `<select>`

Using currentcolor for backgrounds seems not great if we're using it for foreground too. I'd much rather use `light-dark(rgba(0, 0, 0, .05), rgba(255, 255, 255, .1))` or so. In any...