Emilio Cobos Álvarez

Results 777 comments of Emilio Cobos Álvarez

Ah, I grepped for `interface HTMLDocument`, of course... Thanks!

Fairly sure this is https://github.com/rust-lang/rust-bindgen/pull/2372 basically, which unfortunately also needs LLVM changes and I haven't found the time to push forward.

It seems the test is mostly fuzzy, not broken? Maybe using `animation-play-state: paused` rather than `animation-duration: 500ms` helps mitigate it

(On the other hand it's `visibility: hidden`, so shouldn't matter I think? I can look at it more tomorrow, feel free to land as-is)

@mattwoodrow so running the test on firefox nighly, I see that what happens is that we capture the old state just fine because it's not fragmented yet, and then fade...

Feel free to merge it, I can dig into this next week / as time allows. But Matt's comment makes sense to me.

It seems ok if we fix it to match the spec :) fwiw I think Firefox / Chrome are right. I don't think we want to make `@supports` syntax context-dependent...

Also could you squash before I hit the merge button? A lot of the commits don't have particularly descriptive commit messages (like `cargo fmt`)

Ok so I dug into what's going on. The key difference between how bindgen tracks bitfields vs. LLVM is that we track the offset within the bitfield, but llvm tracks...