Emilio Cobos Álvarez

Results 779 comments of Emilio Cobos Álvarez

> As indicated in https://github.com/rust-lang/rust-bindgen/issues/1892 the stable usage in the [book](https://rust-lang.github.io/rust-bindgen/using-fam.html) violates stacked borrows. This kind of pattern is tracked in https://github.com/rust-lang/unsafe-code-guidelines/issues/256. I guess the nice thing is that we...

I would prefer, I think, making blocklist_type("__BindgenBitfieldUnit") work and documenting it I believe

Which rust version are you using? We have code to deal with this, see https://github.com/rust-lang/rust-bindgen/commit/a380678490b821201f10b861144b15bbe08694a2

Ah, so I couldn't repro this, but that's because for some reason `--target=x86_64-pc-win32` is needed to repro: ``` ./target/debug/bindgen --with-derive-default t.h -- --target=x86_64-pc-win32 ``` Is the command I used to...

And somehow that only happens when targeting windows

I think that limitation in rustc is mostly historical? https://github.com/rust-lang/rust/pull/124163 removes it.

I'd be against making the bitfields code more complicated. We can add the `#[allow(clippy::useless_transmute)]` on the generated code tho...

Assuming that they don't affect the layout of the type, it'd be doable, yeah... But I don't think that's the case, for example: ```c struct Foo { struct { uint64_t...

Right, adding padding and alignment bits should be doable, though it may not be as trivial.