Emilio Cobos Álvarez
Emilio Cobos Álvarez
Of course the more we can automate after that the better, but that's not a strict requirement imo.
I think this was done on purpose on a9497fb3 to not bloat the archive
(Not that this is necessarily wontfix I guess, just pointing that out) This was done in #116 to help with https://bugzilla.mozilla.org/show_bug.cgi?id=1336655.
Yeah I don't see a much better way to do it than what @SimonSapin suggested above... We could check the existence of the json file, but that'd risk tests actually...
Happy to take a patch here as long as it's well documented how to tweak it as needed. Specially since those colors are not gonna change any time soon...
So the issue is that errors have `CowRcStr`s, right? I don't think we really want to turn such thing into something that's `Send`, it's very intentional to avoid performance overhead....
Yeah, I think that same-thread sends and recvs shouldn't be allowed. Ideally this would be enforced, but this is hard. I wonder if Servo uses that a lot... I hope...
This is not for merge yet, until we find a fix.
Btw @dlrobertson @antrik, in case you have any bright idea about this, it'd be definitely appreciated! STR are in https://github.com/mozilla/rr/issues/2128.
Something funny. With the following patch applied: ```patch diff --git a/src/test.rs b/src/test.rs index 0a7e034..4cdce42 100644 --- a/src/test.rs +++ b/src/test.rs @@ -187,10 +187,12 @@ fn stress_in_process() { } thread::spawn(move || {...