Emilio Cobos Álvarez

Results 779 comments of Emilio Cobos Álvarez

Setting RUSTC_BOOTSTRAP from a tool is a big no-no. The right thing to do, if this option is stable-ish, would be to stabilize it on the rust side (https://github.com/rust-lang/rust/issues/43364)

Yes, this is what `opaque_type` causes when used on this kind of stuff... That being said, it seems to me it's a rust bug to complain that `*const root::example_type` is...

Yeah this looks like a bug. Unfortunately our bitfield generation is kinda reverse-engineered from LLVM, it seems we're getting that case wrong. Fixing and adding it as a test would...

This might be a dupe of https://github.com/rust-lang/rust-bindgen/issues/1377

Yes, that's right. I've opened https://github.com/rust-lang/rust-bindgen/issues/1606 to track this.

@aminomancer anchor position and so on is exposed in the `popuppositioned` event, right? [here](https://searchfox.org/mozilla-central/rev/5a7e5e2e1fe04028fc77787084caf9b26ab74ce6/dom/chrome-webidl/PopupPositionedEvent.webidl)

> I don't like the idea of complete animation suppression for view transitions only. It should be done at a lower layer, for CSS transitions, CSS animations and web animations....

This looks actually pretty hard to fix, looks like the compiler packs the `uint32_t` bitfields right after the union, which is another member altogether. A bit reduced: ```c typedef unsigned...

A bit more reduced, without the extra struct: ```c typedef unsigned char uint8_t; typedef unsigned uint32_t; struct Bar { uint8_t foo; uint32_t ns_attr_notice: 1; uint32_t fw_activation_notice: 1; uint32_t telemetry_log_notice: 1;...

FWIW would be _great_ to get these regressions reported earlier to Firefox as well, even if there's a workaround available on the extension's side :) https://bugzilla.mozilla.org/show_bug.cgi?id=1906132 tracks this, about to...