Emilio Cobos Álvarez comments

Results 779 comments of


                                            Emilio Cobos Álvarez

Consider rewriting the parsing back-end as a clang plugin instead of using libclang.

Potentially, yeah! That looks exciting. Do you know what's the story for using it (clang version requirements, etc.)?

Generate bindings to explicitly instantiated function templates

> Forward declaring specific functions in wrapper.hpp like: void myFun(float* arr); void myFun(double* arr); (without template keyword): Generates 2 bindings per myFun with specific function names, linker error running tests...

Reinstate <style scoped>

@heycam is who implemented it originally, maybe he has more input. I don't think I'd personally have time right now to spend in writing a spec for ``. Note that...

Render-blocking: the definition of "created by its node document's parser" is a little bit vague

In particular, it's easy to track whether an element came from the parser, but not so much which document it came from (that's what the spec says roughly to do)....

Render-blocking: the definition of "created by its node document's parser" is a little bit vague

I think an element should be render-blocking if it's parser-inserted, but should stop being render-blocking as soon as it is detached from its tree... `document.write`-injected stuff should probably be render-blocking....

Dialog should be better-behaved on misuse, probably

Yeah, to be clear I don't have a super-strong opinion here. It's just weird that removing an attribute can leave the page in a fully broken state. I was reviewing...

Don't force <details> to be a block.

`` in Gecko doesn't have such restriction, fwiw.

config: Stabilize binop_separator again.

@ytmimi review ping?

config: Stabilize binop_separator again.

Ping here?

config: Stabilize binop_separator again.

Thanks for the update!