Emilio Cobos Álvarez comments

Results 779 comments of


                                            Emilio Cobos Álvarez

script: Do not run layout in a thread

@mrobinson do we have data on how often script blocks on layout? It seems that modulo layout queries it shouldn't?

`with_parse_expand(...)` from build.rs seems to hang indefinetly

Can someone bisect this by any chance? Should be easy to identify the broken commit.

[css-conditional] Make CSSSupportsRule expose whether its condition is met

@fantasai looks good to me.

[css-viewport] [css-device-adapt?] Really create a css-viewport spec

This has been done (https://drafts.csswg.org/css-viewport-1/ exists) so this issue should be closed. Let's discuss that in a new issue :)

[cssom] The way CSSStyleDeclaration exposes properties is not ideal.

@gsnedders Setting a descriptor "works" for some rules, like `@page` at least.

[cssom] The way CSSStyleDeclaration exposes properties is not ideal.

That's basically https://drafts.csswg.org/css-fonts-4/#om-fontpalettevalues right? Edit: hah, I hadn't seen the edit. I don't think exposing descriptors in a declaration block is super-desirable.

Should we standardize the anatomy of `<input type=range>`?

I wouldn't like to block `::slider-thumb` on a potential `::slider-thumb(n)` / `::slider-thumb-two` or so pseudo... It seems we could implement multiple thumbs in the future if needed. cc @hober, fyi.

[css-values] Clarify fragment URLs resolve against the current tree, not document tree

@annevk @tabatkins my point was that there are two orthogonal issues: * Whether `` is respected or we should just ignore and treat as local refs. * Which tree we...

Emit `_Nullable` alongside `_Nonnull`

Patch welcome :)

Merge generic enum tags

Thanks, if CI is green this looks good. Can you squash your commits in the way you best see fit so that we don't have "Tidy up" commits? Or would...