Emilio Cobos Álvarez

This line just doesn't work cross-origin, because cross-origin frames don't have a docShell in the embedder process (it lives in the frame's process): https://github.com/microsoft/playwright/blob/bff97b481092b7a5bbe199f359ad86c26d30e078/browser_patches/firefox/juggler/content/PageAgent.js#L411 However it could be replaced by...

This can certainly be supported, though it'd be kind of a one-off. Indeed I think this eventually worked (by chance) because at one point we tried to find just the...

Yeah, that'd work better. I've also just realized we can't just strip wrapping parentheses since they can change the precedence of operators.

I guess you'd need to define them manually :/

@xxks-kkk I'd consider using the `log` crate for your rust code. You can then add a `logger` implementation that forwards to `spdk_log` if you need to, but it'd probably be...

The right way to specify a type is using `static const`s, fwiw: `static const int32_t FOO = 1;`. There's a way to specify the type for the `#define`: https://github.com/rust-lang/rust-bindgen/blob/1c31f29e4e5d514e6df14d2e82662de7e947c2af/src/callbacks.rs#L34

That needs `cexpr` support, basically: https://github.com/jethrogb/rust-cexpr is what we use to parse the macros and only has i64 support. It should probably at the very least return a u64 for...

I've started experimenting with this in https://github.com/emilio/rust-bindgen/tree/clang-plugin. @fitzgen, would you be interested in reviewing and getting this in-tree once it's minimally working? I don't plan to do this the default...

> So, with all that said, I am relatively eager to replace our frontend with something better. I've never written a clang plugin either, so my question is: does using...

I think this would still be nice to do (plus will make bindgen saner / faster in general, I'd think). I don't think I'll have the time for it near-term...