Mason Reed

> What is a memory version? SSA for memory :) https://www.airs.com/dnovillo/Papers/mem-ssa.pdf Note the @ mem#7 ``` 000471b0 (HLIL_ASSIGN (HLIL_STRUCT_FIELD (HLIL_VAR_SSA x0_12#1).d) = (HLIL_DEREF_FIELD_SSA s_aircraftBaseInfo.aircraftSeries @ mem#7)) 000471b0 (HLIL_ASSIGN (HLIL_STRUCT_FIELD (HLIL_VAR_SSA...

This isn't really a bug, if a user wants they can rename the vtable type so they can refer to the decl without preparing the type beforehand. This naming convention...

The logger constructs a `log` crate compatible sink so that when you have `log::info!("test")` the logs are output to the binary ninja logger. What you want is to register a...

So there are two issues here: 1. We were showing the add memory region dialog in "Raw" view, which is not intended behavior. 2. We do not support writing OOB...

The push / pop lifting looks fine on the binary https://github.com/user-attachments/files/23866882/apxbin.zip

CCMP also looks correct, the conditional CMP block and the DFV write block look fine.

> Thanks for the test bin - I'll be sure to test against that; do you have a corpus for the other extension instructions? I do not, I will make...

The solution for only registering the notifications is fine with me, I will be able to review this more once testing is done for the upcoming 5.0 release. Thank you!

When constructing the data notification it is very important that we not copy/clone the `BNBinaryDataNotification` otherwise when we go to unregister the notifications we will be keying off a different...

> If I understand your comment correctly, then you are doing a pointer equality check during deregister? In that case a `Box` is not enough, you need a `Pin`: Yea...