Mason Reed

Results 106 comments of Mason Reed

This is probably best done as a data renderer. Having just a bare xref is limiting.

It should be noted that current arm builds of binary ninja are mac and (on nightly) Linux. We shouldn't need to build for windows.

This is blocking on #3

This is blocking on https://github.com/Vector35/community-plugins/issues/248

We could also inline the non-exceptional path like so: ![image](https://github.com/emesare/binja-msvc/assets/35282038/8288409c-acfe-4fda-8742-327855b11fe6)

Once we can identify destructors most of the false positives for constructor detection will be gone

Also happens frequently with `msvcrt_windows-x86_64.sig`. https://dogbolt.org/?id=1701d225-02d4-4210-8f99-9d230c9e0418#Hex-Rays=185&BinaryNinja=54 In this case because of the similarities between c++ vfuncs and constructors they often will match against each other.

Closing this as we have enabled WARP by default (as of dev `5.1.7824`, users are free to disable sigkit. Re-open if you see `Concurrency::*` functions start getting added to the...

Adding to the Helion milestone, WARP uses this for the loading/creating of files.

The output looks to be correct from the given screenshots 👍