Emanuel Peter

Results 51 comments of Emanuel Peter

@reinrich please ping me again to ask if testing is ok before you integrate ;)

@reinrich please still wait until the JDK24 fork on Thrusday to integrate, so that we do not have to backport possible regression fixes - I had 3 or 4 with...

Thanks for the reviews @vnkozlov @chhagedorn ! /integrate

Also: what if the `UseAPX` is enabled, but the hardware does not support the feature? Don't we usually then automatically disable the flag, if the feature is not present? We...

And I agree with @dean-long : you need to have some test for this. At least some test should have the flag enabled. Something that stresses the registers, and verifies...

Can the APX features be simulated, maybe even with SDE? Now you made the flag EXPERIMENTAL and by default false. What is the roadmap with this? It is generally not...

@steveatgh I just saw that we from Oracle did not run any tests for this. Can you please hold off for a day or two until we have the testing...

Thanks @chhagedorn for the review! I think I addressed all your points. Except for this: > You should mention here that this method finally adds a new pair to the...

FYI: I ran performance benchmarking, and there was no significant difference.

@vnkozlov thanks for the review! I will integrate as soon as the JDK24 fork happens ;)