jdk icon indicating copy to clipboard operation
jdk copied to clipboard

8329273: C2 SuperWord: Some basic MemorySegment IR tests

Open eme64 opened this issue 10 months ago • 6 comments

I could not find any IR vectorization tests for MemorySegment yet.

I make sure to exercise different backing types:

  • arrays
  • buffers
  • native memory

I filed a follow-up RFE, to eventually make all cases where I have "FAILS" vectorize:

JDK-8331659: C2 SuperWord: investicate failed vectorization in compiler/loopopts/superword/TestMemorySegment.java


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8329273: C2 SuperWord: Some basic MemorySegment IR tests (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18535/head:pull/18535
$ git checkout pull/18535

Update a local copy of the PR:
$ git checkout pull/18535
$ git pull https://git.openjdk.org/jdk.git pull/18535/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18535

View PR using the GUI difftool:
$ git pr show -t 18535

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18535.diff

Webrev

Link to Webrev Comment

eme64 avatar Mar 28 '24 16:03 eme64

:wave: Welcome back epeter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Mar 28 '24 16:03 bridgekeeper[bot]

@eme64 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329273: C2 SuperWord: Some basic MemorySegment IR tests

Reviewed-by: kvn, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 3e3f7cf4bddf243fddfeac8cfc1d9b2a1be55043: 8330387: Crash with a different types patterns (primitive vs generic) in instanceof

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Mar 28 '24 16:03 openjdk[bot]

@eme64 The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk[bot] avatar Mar 28 '24 16:03 openjdk[bot]

@eme64 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar May 03 '24 21:05 bridgekeeper[bot]

Webrevs

mlbridge[bot] avatar May 06 '24 06:05 mlbridge[bot]

⚠️ @eme64 This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

openjdk[bot] avatar May 13 '24 07:05 openjdk[bot]

Thanks for the reviews @vnkozlov @chhagedorn ! /integrate

eme64 avatar May 15 '24 13:05 eme64

Going to push as commit c4867c62c44b48e48845608fe4b29b58749767ad. Since your change was applied there have been 29 commits pushed to the master branch:

  • 8032d640c0d34fe507392a1d4faa4ff2005c771d: 8332245: C2: missing record_for_ign() call in GraphKit::must_be_not_null()
  • fa043aec425ae1e3086d09492b3fabcfbd3fa779: 8294880: Review running time of jdk/internal/shellsupport/doc/JavadocHelperTest.java
  • a5005c87c4d5598eb54e9824105767d833f9660b: 8330814: Cleanups for KeepAliveCache tests
  • 1a944478a26a766f5a573a1236b642d8e7b0685c: 8332111: [BACKOUT] A way to align already compiled methods with compiler directives
  • 957eb611ce2531a3fcc764813ad1e0776887fdda: 8331429: [JVMCI] Cleanup JVMCIRuntime allocation routines
  • 2f10a316ff0c5a4c124b94f6fabb38fb119d2c82: 8302850: Implement C1 clone intrinsic that reuses arraycopy code for primitive arrays
  • c642f44bbe1e4cdbc23496a34ddaae30990ce7c0: 8329839: Cleanup ZPhysicalMemoryBacking trace logging
  • d04ac14bdbab4187d0be98b8471f90be8a14f649: 8332236: javac crashes with module imports and implicitly declared class
  • 4e77cf881d031e5b0320915b3eabd7702e560291: 8330795: C2: assert((uint)type <= T_CONFLICT && _zero_type[type] != nullptr) failed: bad type with -XX:-UseCompressedClassPointers
  • 7b4ba7f90ab9ea5e1070c79534c587dad17d1bdd: 8325932: Replace ATTRIBUTE_NORETURN with direct [[noreturn]]
  • ... and 19 more: https://git.openjdk.org/jdk/compare/d517d2df451e135583083ed3684d7d3241b36f76...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar May 15 '24 13:05 openjdk[bot]

@eme64 Pushed as commit c4867c62c44b48e48845608fe4b29b58749767ad.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar May 15 '24 13:05 openjdk[bot]