Emanuel Peter
Emanuel Peter
@chhagedorn > Have you checked that the printed node order with `dump(X)` is the same as before? I'm not sure if that is a strong requirement. I did try to...
Thanks @chhagedorn @navyxliu for the review and comments! /integrate
> > I guess the issue is that ConvL2I and ConvI2L are also type nodes, which can restrict their type, just like CastII nodes. And that restricting of the type...
@rwestrel which "split_if" optimization was applied in your example? Split the ConvI2L through the phi? If so, the problem seems to be that the ConvI2L floats by the exit-check, right?...
@rwestrel Yes, I'm totally fine with the fix. It simply applies the `int` case to `long`. In a future RFE, we could at least restrict the "bailout" to trip-count Phi's,...
Looks interesting! Will have a look at it. /reviewers 2 reviewer
A suggestion about naming: We now have a few synonyms: ``` Unordered reduction non-strict order reduction associative reduction ``` I think I introduced the "unordered" one. Not proud of it...
On a more visionary note: We should make sure that the actual `ReductionNode` gets moved out of the loop, when possible. [JDK-8309647](https://bugs.openjdk.org/browse/JDK-8309647) [Vector API] Move Reduction outside loop when possible...
You probably want to change the name of the PR again: `Add "is_associative" flag for floating-point add-reduction` -> `8320725: AArch64: C2: Add "requires_strict_order" flag for floating-point add-reduction`
Sorry for the delay, I'm really excited about this one, just had to get some more critical things done recently ;)