elomscansio
elomscansio
I think there's no need for implementing for subtypes as they all refer to `Ieee8021XConfig.private_key_password`
> https://github.com/nmstate/nmstate/blob/base/CONTRIBUTING.md#write-a-good-commit-message, please make sure that the commit message is wrapped around 72 characters? I have amend the commit
I have made the requested changes
I have squashed the commits
See fn test_nlpm: https://github.com/elomscansio/nmstate/blob/d27dd2ddc553e241f17f1350fdfb6f5c7171032e/rust/src/lib/unit_tests/nlpm.rs#L4 fn nlpm: https://github.com/elomscansio/nmstate/blob/d27dd2ddc553e241f17f1350fdfb6f5c7171032e/rust/src/lib/nlpm.rs#L10 print: https://pastebin.com/ENXNYiEs
Concerning the bad code structure, this is just a demo so i'm still test running stuff
Hello, @ffmancera @cathay4t @ihuguet I'm currently waiting for your responses to proceed with the [PR](https://github.com/nmstate/nmstate/pull/2647). For example, after extracting the required details with NLP, should I create a NetworkState instance,...
> It doesn't look bad, but you've changed the formatting of the whole file. Please apply only the parts that need to be changed. I run `cargo fmt` since Rust...
> > I run `cargo fmt` since Rust formatting is checked by `cargo fmt` during CI runs. > > We all run it and it doesn't change the file. Has...
> I don't know what happens, I would say that you are applying a different formatting style. If I run `cargo fmt` or `rustfmt src/cli/ncl.rs` nothing changes for me. On...