elomscansio
elomscansio
Hello, is this something i can work on
Hello @mfocko I would love to work on this
I have made the suggested changes
I have made the changes
I have made the necessary changes
> Thanks for the changes. Regarding "adding all the missing SPDX lines in a separate commit", what I mean is to add the line `# SPDX-License-Identifier: LGPL-2.1-or-later` or `// SPDX-License-Identifier:...
i have added the license header fixing but i need help here https://github.com/nmstate/nmstate/actions/runs/8452081881/job/23151720812?pr=2617#step:3:431 https://github.com/elomscansio/nmstate/blob/930c58db6d41e22dc2990cf25d81f47120d26e30/tests/license_header_check.py#L144
> Now it's great, contratulations for the good work! The CI is failing because it tries to merge the `base` branch with yours and find a conflict. Please rebase your...
> @elomscansio , there is a conflict when merging it, can you resolve the conflict? I have addressed the conflict.
I have been able to use skywalker see https://github.com/nmstate/nmstate/pull/2704. But i have to create two config file for each header check