Michael McCune

Results 369 comments of Michael McCune

it looks like the unit tests also carry this spelling error, https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/capacitybuffer/testutil/testutil.go#L102 which is a real head-scratcher to me, perhaps we should make a constant for this value?

also, these functions need to be updated: https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/capacitybuffer/common/common.go#L84 https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/capacitybuffer/common/common.go#L95

just starting to review this, but i think it would be nice to update the proposal as well with the new capacity case.

i'm updating the title and content here in preparation for making the announcement on kubernetes-dev about the deprecation.

leaving this open so folks can see it, and ask questions or leave comments. /remove-lifecycle stale

this component is being archived and deprecated as the service is being discontinued. /close