Michael McCune
Michael McCune
/remove-lifecycle stale @JoelSpeed i'm guessing that the special leader election stuff has merged at this point?
@aojea thanks for posting this! was on pto for a few days, will review this week. @carlory we still allow, and require in some cases, the `--cloud-provider=external` flag, i don't...
awesome, thank you so much @aojea ! (fwiw, this is where i hoped to get in terms of code removals)
lgtm, would like to get another review
this looks good to me, i am unfamiliar with the error coming from pull-kubernetes-integration, is that related to this change?
thanks @sbueringer !
looks like the github names are incorrect here, they should be @joelsmith and @maxcao13 , additionally should i be on these?
here's an owners file we use for reference, https://github.com/openshift/kubernetes-autoscaler/blob/main/OWNERS
+1 from me, i think we should be updating the e2e test configs whenever we bump the k8s, or any core, dependencies.
we are discussing in the sig cloud provider office hours today, we think this is a good topic for further investigation, but we don't think there is a way to...