Michael McCune

Results 131 comments of Michael McCune

we talked about this issue during the install flex sync meeting today, we don't think this is overly concerning but it will be an issue for people who want to...

> Are you asking what would happen when users downgrade their VPA? @voelzmo yeah, that's more what i was asking about. apologies for the confusion. > I don't think there...

i am placing a pre-empitve hold on this to allow time for reviews. /hold for reviews @enxebre ptal

updated to remove redundant checks for cpu and memory data

update * rebased * removed infrastructure machine template cache * improve unit tests based on review comments i am doing some manual testing now to make sure nothing broke, but...

manual testing is working as expected against capi 1.0.5 and kubemark 0.3.0

fyi, i'm leaving this on hold so we don't merge early since it's already approved. i will remove the hold once we work out the last discussion item.

update * removed all references to the custom cache * squashes down to 2 commits

i'm doing some digging around client-go, have found https://github.com/kubernetes/client-go/tree/master/tools/cache but i think we need to add a little more code to make it work. i was under the false impression...

i talked with @JoelSpeed a little about client-go internals, i think what i need to add here is the ability to add new informers to the client when we observe...