Marc-Andre Lureau

Results 67 comments of Marc-Andre Lureau

> 2\. The mentioned article about Hyper-V sockets, and AF_VSOCK is used by Linux guests to create such a socket and is not defined for Windows guests which use AF_HYPERV...

I think this should be fixed with #129.

I ran exactly on this error yesterday, and I can confirm your fix works for me. Good to merge imho, thanks :)

Hi @punkstarman any chance you look at it? thanks

Does that look on the right path? https://github.com/gtk-rs/gtk-rs/commit/bd74925488150fd2e980ef4e5f73078bdfa150f1 Unfortunately, we don't have ToGlibPtr for fundamental types. Am I missing something? (the test fails with bool/u32, works with &str) Otherwise, I...

> I think this is supposed to take e.g. a `gboolean *` in case of `bool`, `guint32 *` in case of `u32`, etc. Your approach of implementing that will need...

@sdroege the idea is to replace BoolError with more specific errors for the various domain/cases? Similar to value::GetError, for other types?

What about public functions that return BoolError? Should we just switch to a different type? Should BoolError wrap the specific type?

Looks good otherwise. It would be nice to have a test for it, and some quote of the specification

> I am wondering whether to add a flag `--flags auto-shutdown` to enable this feature. Perhaps the other way around (disable-auto-shutdown), if we believe the new behavior is a fix...