Marc-Andre Lureau
Marc-Andre Lureau
@aldanor are you still maintaining the crate? thanks
> The api feels kinda confusing too me. It would be cool to control Input format and output format independently. I have the use case that I have an image...
> > You need alpha channel input for alpha channel output. > > Adding an alpha channel with default values of 255 would be imho fine and not unexpected. Well,...
> Why is `RawChannels::bytes_per_pixel` not public? There should either be another Encoder constructor without a stride argument or `bytes_per_pixel` should be public. Otherwise the `Encoder::new_raw` API is imho too clunky...
@aldanor thanks for the review > * can you run the benchmark before/after on the encoder and post the results, to make sure that double nested loop in the encoder...
> Yea, -33% is pretty bad for sure... -3% would still be not nice but within noise bounds. it turns out it's the assert_eq!(), this adds a bunch of panic...
did you compile with --release ?
(I switched to stable rust, as I get slightly different results with nightly which can create confusion) @Joshix-1 try with the latest commit. You should not see performance loss (I...
@Joshix-1 I am really curious to know how you found about adding this extra E/Infallible !
I tried to make a subset test case to report to the compiler without success atm. @Joshix-1 what to do next?: - use your workaround - add the feature flag...