Elliot Chance
Elliot Chance
Your missing a few things here before this can be merged in: 1. Update the README with the new service. 2. Unit tests for your service. 3. An example isn't...
That's interesting - thanks for tracking down the commit. You say the king doc say that `oauth_verifier` is required but it only works when you don't provide it? Perhaps the...
I have reverted this change in v0.8.1, please test again.
I reverted it because another service (QuickBooks) was broken because of this change. The original change went in as part of fixing up a Yahoo service so it's more likely...
Reviewed 5 of 5 files at r1. Review status: all files reviewed at latest revision, 3 unresolved discussions. --- _[src/OAuth/OAuth2/Service/Todoist.php, line 10 [r1]](https://reviewable.io:443/reviews/lusitanian/phpoauthlib/467#-KGzzJj-YzxPLE1BVaXV:-KGzzJj-YzxPLE1BVaXW:-149383282) ([raw file](https://github.com/lusitanian/phpoauthlib/blob/3afd4a0e90c237c2106e718acb12c9e74ca04506/src/OAuth/OAuth2/Service/Todoist.php#L10)):_ Is this comment supposed to...
@ThomasJoergensen please add unit tests for this to be accepted.
Is it possible this is anything in your internal network interfering with this (like a proxy)? Have you found a way to replicate the issue?
Which version of this library are you using?
Reviewed 6 of 6 files at r1. Review status: all files reviewed at latest revision, 5 unresolved discussions. --- _[composer.lock, line 1 [r1]](https://reviewable.io:443/reviews/lusitanian/phpoauthlib/466#-KCXfgEISUfiOV3i0Gga:-KCXfgEISUfiOV3i0Ggb:-1458390982) ([raw file](https://github.com/lusitanian/phpoauthlib/blob/834462495547faffde8f709ed500dab6ed992881/composer.lock#L1)):_ Are these changes just part...
Please provide unit tests like the other services. --- Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved. --- _Comments from...