Elliot Chance

Results 282 comments of Elliot Chance

All of the existing test cases are from real data. If you create synthetic tests for cases that do not exist it will just muddy this. Panics from reading the...

This is related to other issues where constant statements can be evaluated at compile time. Once the AST is loaded from `clang` we will have to do our own parse...

This is a tricky one because I'm not sure what the AST node is supposed to mean... I can't play with the code right now but what I suggest you...

The fix here would be: 1. Replace all the cases of `goast.NewIdent` with `util.NewIdent`. 2. Add a step to the Travis [lint.sh](https://github.com/elliotchance/c2go/blob/master/travis/lint.sh) script to prevent it from being introduced in...

This was closed by mistake, reopening.

Yes, that looks like a great set of tests to run through! 👍

Is the expected behaviour that that first `sprintf` is always executed no matter what the value of `*mode` is?

@Konstantin8105 do you know what is causing this?

I agree and I have thought about how this could be done in a way that would not allow the progress to regress (new PRs creating new errors/warnings) but I...

Leave this issue open, i've marked it as a question.