Eli Miller

Hey @samhforbes I can review

@eddelbuettel You're right about [`--install-tests`](https://support.rstudio.com/hc/en-us/articles/200486518-Customizing-Package-Build-Options). Testing the installed packages as well as the base packages is also an important part so those tests would ideally be there. Let me know...

Hey @mstackhouse That is updated. Here is the new functionality: ``` load(test_path("adae.Rdata")) tmo % tplyr_table(TRTA) %>% add_layer( group_count(vars(AEBODSYS, AEDECOD)) %>% set_numeric_where(3, "n", "Placebo") %>% add_total_row() ) %>% build() # A...

@mstackhouse I'm thinking we would want total row functionality for shift layers. Not sure how common that is but the functionality makes sense and I don't think it would be...

@mstackhouse This is working in devel: ``` t % add_layer( group_count(gear) %>% set_format_strings(f_str('xx (xx.x) xx', n, pct, total)) ) %>% build() ```

@kcaashish Thanks for the request. in the meantime you can make each table then run `mutate(Statistic = "N (%)")` on the count tables then rbind them together. @mstackhouse I'm thinking...

## Review checklist for @elimillera ### Conflict of interest - [x] I confirm that I have read the [JOSS conflict of interest (COI) policy](https://github.com/openjournals/joss/blob/master/COI.md) and that: I have no COIs...

Hey @pydemull, I've reviewed the package, repository, and paper. I've ran all the tests I generally run to determine package quality and they are all coming back green, they repository...

Update documentation in xportr to point at [metatools::drop_unspec_vars](https://pharmaverse.github.io/metatools/reference/drop_unspec_vars.html) for this functionality.

@bms63 I can take this up once I'm back from vacation