Elijah ben Izzy

Results 285 comments of Elijah ben Izzy

Nice work! Given that this is an in-progress PR, I'll leave the following feedback: 1. Structure/approach looks good -- we want to ensure the API is good. Means deciding whether...

@jernejfrank happy to look at the implenentation next, first took a look at the API. I really like it! Only question I have -- the `targeted` is clever, but my...

> These two functionalities achieve the same thing > > ```python > %%cell_to_module -m pipe_output_with_target --display > from typing import Dict > from hamilton.function_modifiers import extract_fields, pipe_input, pipe_output, step >...

> > > Yes more dev --> but the idea is that we can provide prod introspection, so ideally you wouldn't need to change things. So I wouldn't expect people...

> > > Something to think about/a caveat: > > > > > > 1. If `@mutate` runs once it's good > > > 2. If you run that again,...

@eric-czech -- nothing that would make this impossible! It's quite doable. In fact, we have https://hamilton.dagworks.io/en/latest/reference/drivers/Driver/#hamilton.driver.Driver.visualize_execution which should get you most of the way there!

> Burr is not working anymore because of the updates of scrapegraphai and I would like to integrate pricing informations Hey do you ahve updated on what's broken? Is this...

Ok, it works for me -- what version of `click` do you have? I did this: `pip install "sf-hamilton[cli,visualization]" --no-cache` `Python 3.12.4`

> Here's my best understanding of the setup: > > * Hamilton requires `"click>8.0.0"` (only [in contrib/setup.py](https://github.com/apache/hamilton/blob/main/contrib/setup.py#L71)) > * Hamilton requires `typer` (no version specified) [in ui/backend/setup.py](https://github.com/apache/hamilton/blob/main/ui/backend/setup.py#L13) and [pyproject.toml for...

@pjfanning this is purely an example. I'm wondering if it's worth having a separate repository that's a not as strict apache-licensed software for examples. That has a lot of the...