Elijah ben Izzy
Elijah ben Izzy
> LOL, I'm sure methods will need to be written a certain way with this approach... Instead of Ruby on Rails, I propose we call the approach Hamilton on Ice....
OK, I had some thoughts about this, but I wanted to move issues as we've moved a bit beyond this one :) I *do* think the implementation of this issue...
This is pretty similar to this issue: https://github.com/DAGWorks-Inc/hamilton/issues/90
Feels like the same pattern as `extract_columns`, no?
Changes one might need to make: 1. Change [this](https://github.com/DAGWorks-Inc/hamilton/blob/6ecb007aa0ec2de56b6dcb784bd7edc90f529fd6/hamilton/function_modifiers/validation.py#L54) to add any non-static dependencies 2. Loosen the validation here -- instead wire through the type as the validator type --...
Copy of https://github.com/stitchfix/hamilton/issues/139 -- automated migration script did not work for this one.
@gravesee -- was thinking about this recently and realized it got buried in the repo migration. Happy to start up the conversation again if this is still interesting!
Awesome, yeah, so I prototyped it a bit back, but I want to revisit it: https://github.com/DAGWorks-Inc/hamilton/pull/98 (just created but that was in the old repo). This basically used `TypedDict` to...
> just What would that look like re: code? We still have to return the final result + state update.
OK, working on this shortly. @skrawcz your API makes a lot of sense IMO (although I think needs an async for loop in the loop through response).