hamilton icon indicating copy to clipboard operation
hamilton copied to clipboard

Typed Tag Metadata

Open elijahbenizzy opened this issue 2 years ago • 3 comments

From this discussion -- I think this is something we likely want to support:

https://github.com/stitchfix/hamilton/discussions/276

elijahbenizzy avatar Mar 04 '23 18:03 elijahbenizzy

@gravesee -- was thinking about this recently and realized it got buried in the repo migration. Happy to start up the conversation again if this is still interesting!

elijahbenizzy avatar Mar 04 '23 18:03 elijahbenizzy

@elijahbenizzy thank you, this is still of interest to ensure we don't contaminate metadata with typos, etc... I am happy to kick the tires on any proposals.

gravesee avatar Mar 04 '23 21:03 gravesee

Awesome, yeah, so I prototyped it a bit back, but I want to revisit it: https://github.com/DAGWorks-Inc/hamilton/pull/98 (just created but that was in the old repo). This basically used TypedDict to validate tags, which worked fairly cleanly IIRC. Need to dig in and stick it on the queue. The other optionis an external schema of sorts, which kind of reminds me of this one (schema of inputs versus schema of tags) https://github.com/DAGWorks-Inc/hamilton/issues/97?notification_referrer_id=NT_kwDOADtM47I1NzY5Mzc4MTc4OjM4ODYzMDc#issuecomment-1454908958

elijahbenizzy avatar Mar 04 '23 22:03 elijahbenizzy

Please reopen - provide more input if needed. Closing for now since we haven't moved on this in a while.

skrawcz avatar Jul 18 '24 18:07 skrawcz