Eli Chadwick
Eli Chadwick
Location: workshops/models.py > Membership class 1. Update/split out queried/computed model properties like `_workshops_without_admin_fee_queryset` and `workshops_without_admin_fee_total_allowed` to count online and inperson workshops separately. Note that the `workshops_discounted_completed`/`workshops_discounted_planned` properties actually mean (and...
For guidance see #2387 .
Location: workshops/models.py > Membership class 1. `workshops_without_admin_fee_per_agreement` should be split and renamed to create the four fields above. Pick one field to migrate all existing data into (or let Django...
Actually, to avoid the problems with tests, you could instead add all the new fields _and_ keep the old fields while working through the development. So no `RenameField` steps in...
The key concept here is known as _[idempotence/idempotency](https://medium.com/cache-me-out/understanding-idempotency-68a50a837fc1)_. I'm roughly following this article to implement this for our `Create*` views: [Idempotence and POST Requests in Django](https://dev.to/ck3130/idempotence-and-post-requests-in-django-2bbf). This should be a...
There is a lazier option here, which is to insert a bit of JS everywhere to disable submit buttons on submit. But the solution described above would work for both...
@karenword could the ITT discuss this issue at some point and try to settle on the criteria for expiring training/checkout progress? It's not urgent, but I'd like to get the...
Having looked at the AMY code, I think this would be better handled using the new email system, after we've decided how to handle the 'autoresponder' type emails. I'm therefore...
@karenword @klbarnes20 @Talishask @maneesha I told you I would aim to address this issue for the 4.2/checkout release, but I have now decided to leave this out. The other remaining...
We do already display a summary in the admin recruitment view, it's under 'Count workshops taught' for each application (screenshot from local AMY so all 0s): ![Screenshot showing "0 H;...