Elliotte Rusty Harold

Results 445 comments of Elliotte Rusty Harold

Good catch on commit message. Fixed

singlestore is failing again

Yes, we should. It's a little easier and safer to take them out one at a time (unless you think the whole directory can go, in which case I can...

Can we go ahead and merge this one?

Easier to do it one piece at a time. Right now this is ready to remove. No idea when I'll have time to do the rest of it.

Doesn't look like the entire directory can be deleted. There's at least one test class in there; i.e. contains TestNG tests, not just test utilities and mocks.

Best guess: it's running once per test

Maybe, but either way we still don't need both Loading and loaded messages.

another run where this noise obscures the real issue: https://github.com/prestodb/presto/actions/runs/9616802330/job/26527159371?pr=23051