Elliotte Rusty Harold
Elliotte Rusty Harold
On further investigation, I'm not so sure. The API here is really strange. Since the indexes that can be out of bounds are passed in from client code, StringIndexOutOfBoundsException seems...
Letting code fail is fine and avoids extra work on the happy path. If an explicit check isn't needed, it isn't needed. The important thing is to document and test...
Yes, if we can move more classes into the same packages we can reduce visibility of a lot of things. Excessive proliferation of subpackages is a major antipattern in Java...
org.glassfish:javax.json is not private project specific. This is a widely used dependency that shows up in a lot of trees. It ended up in the glassfish project for no particularly...
BigInteger isn't a primitive type, but java.math.BigInteger is available if you need it. Again, I'm not convinced you do. long should work here.
What are the legal values for ip_prefix_length? What's the behavior if a value outside the legasl values is supplied?
> One thing just occurred to me, we should probably link to this document from CONTRIBUTING. sure, let me figure out links work in markdown
Can you resolve the conflicts?
FWIW, if anything, this function does not exist in Spark SQL, so adding this function increases the divergence between Presto SQL and Spark SQL. I don't know how much weight...