presto icon indicating copy to clipboard operation
presto copied to clipboard

Delete TaskExecutorSimulator.java

Open elharo opened this issue 1 year ago • 3 comments

Description

Delete TaskExecutorSimulator.java

Motivation and Context

No longer used

Impact

None

Test Plan

CI

Contributor checklist

  • [x] Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • [x] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • [ ] If release notes are required, they follow the release notes guidelines.
  • [ ] Adequate tests were added if applicable.
  • [ ] CI passed.

Release Notes

== NO RELEASE NOTE ==

elharo avatar Jun 25 '24 20:06 elharo

singlestore is failing again

elharo avatar Jun 26 '24 15:06 elharo

I think there's other things in this directory that can also be deleted, should we remove them as well?

tdcmeehan avatar Jun 28 '24 19:06 tdcmeehan

Yes, we should. It's a little easier and safer to take them out one at a time (unless you think the whole directory can go, in which case I can delete that in a single PR)

elharo avatar Jun 28 '24 20:06 elharo

Can we go ahead and merge this one?

elharo avatar Jul 02 '24 17:07 elharo

I believe the whole directory can be deleted--can you check that it can be deleted cleanly (i.e. there are no external references to the files in this directory)? I'd rather delete all or nothing.

tdcmeehan avatar Jul 02 '24 17:07 tdcmeehan

Easier to do it one piece at a time. Right now this is ready to remove. No idea when I'll have time to do the rest of it.

elharo avatar Jul 02 '24 18:07 elharo

Doesn't look like the entire directory can be deleted. There's at least one test class in there; i.e. contains TestNG tests, not just test utilities and mocks.

elharo avatar Sep 23 '24 18:09 elharo

superseded

elharo avatar Sep 24 '24 15:09 elharo