presto icon indicating copy to clipboard operation
presto copied to clipboard
verified publisher icon prestodb

Prepare function guidelines

Open elharo opened this issue 1 year ago • 2 comments

Description

Elucidate what functions do and don't belong in core

Motivation and Context

Mutliple PRs have been proposing individual functions for very specific purposes without taking a holistic view of what Presto's function library should look like.

Impact

none

Test Plan

CI

Contributor checklist

  • [x] Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • [x] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • [ ] If release notes are required, they follow the release notes guidelines.
  • [ ] Adequate tests were added if applicable.
  • [x] CI passed.

Release Notes

== NO RELEASE NOTE ==

elharo avatar Jul 24 '24 19:07 elharo

One thing just occurred to me, we should probably link to this document from CONTRIBUTING.

tdcmeehan avatar Aug 22 '24 12:08 tdcmeehan

One thing just occurred to me, we should probably link to this document from CONTRIBUTING.

sure, let me figure out links work in markdown

elharo avatar Aug 22 '24 12:08 elharo