Edmund Kump

Results 7 comments of Edmund Kump

I just ran into the same issue with a project I am working on and found this helpful: https://github.com/rust-lang/rust/issues/45599 I changed my Cargo.toml file to make mocktopus an optional dependency...

> The JRuby 9.2.0.0 test failure looks like it is deterministic -- https://app.circleci.com/pipelines/github/DataDg/dd-trace-rb/3520/workflows/c571f62b-cf7f-44ed-bd05-2d134b54a8a8/jobs/138556/tests#failed-test-0 . > > We have 9.2.0.0 because of #1409 but to be honest I'm not [entirely a...

Should we include a section about how to return errors via FFI? Or more broadly, some general API (both Rust and FFI) guidelines?

> One suggestion (just so we don't end up second class citizens) - installing pre-reqs, building, and testing on Windows @andrewlock Good idea! We should include setup instructions for MacOS,...

> We try to keep data-pipeline-ffi as a thin/optional layer over data-pipeline functionalities which are used directly by some crates (e.g. dd-trace-py, dd-trace-rs) > The Span struct and it's logic...

> @ekump So the suggestion is having datadog-trace-utils-ffi, right? My strong opinion is that the real logic doesn't live in an FFI crate. I think it should live in `datadog-trace-utils`...