Ewoud Kohl van Wijngaarden

Fix the rubocop failures to be actually compliant with Foreman's profile? For example, in this repo the `.rubocop.yml` is incompatible with the latest Rubocop so that PR wouldn't even work...

Not sure if I'm reading it right, but it may also be trying to rubocop the installed gems.

It looks like the problem is that you're loading multiple plugins. The fog proxmox plugin is also loaded and that task actually fails. It should be possible to locally replicate...

> if there is any way users could help to keep it going. Note that from the Foreman organization we can add additional maintainers. If anyone is interested, please let...

The test failures look related, probably broke idempotency but not 100% sure.

Is there a label to permanently ignore this one so we aren't spammed on a regular interval.

> After disable the `manage_cron` parameter i expect, that the file and cronjob will be removed. Typically the `manage_*` parameters ensure it's either managed or not. If it's not managed,...

It's a valid point. On Debian (and likely Debian-based) there is indeed a default cronjob (and systemd timer) but there isn't on RH(-based).

I'd guess a `$letsencrypt::manage_cron_per_cert` parameter makes sense. Determine the default `true/false` (probably always true except Debian). Then the define uses that value as a default.

I'm still bothered by this bit: https://github.com/voxpupuli/puppet-zabbix/blob/f4796f1439453610bc4f483a94247f6530313551/spec/defines/startup_spec.rb#L14-L17 The loop there doesn't work as you'd expect. You should really create a `context`, otherwise you only end up testing the last value...