puppet-letsencrypt
puppet-letsencrypt copied to clipboard
Manage Cron parameter on letsencrypt::certonly will not cleanup resources.
Affected Puppet, Ruby, OS and module versions/distributions
- Puppet: any
- Ruby: any
- Distribution: any
- Module version: any
How to reproduce (e.g Puppet code you use)
Use letsencrypt::certonly resource with parameter manage_cron => true, then set this parameter to false
What are you seeing
Renewal script and cronjob for this resource will be applied. After set to manage_cron => false nothing happened.
What behaviour did you expect instead
After disable the manage_cron parameter i expect, that the file and cronjob will be removed.
Output log
Any additional information you'd like to impart
If i use a boolean parameter in a resource i would expect, that if i switch it from false to true and then again to false or vice-versa it should always revert the changes which has be done on the system.
Not sure about this. Do we have any other modules that work like this?
After disable the
manage_cronparameter i expect, that the file and cronjob will be removed.
Typically the manage_* parameters ensure it's either managed or not. If it's not managed, it's fair game because it isn't in the catalog. Often there's also a parameter that ensures it's in whatever state (like present or absent).
IMHO it's fair that you want something to clean it up, but the manage parameter is not the one for that IMHO.