ekaterinadimitrova2

Results 11 comments of ekaterinadimitrova2

About the VT, the conversion happens in the last method in the converter which was not handling the special case, I will fix it in a moment. The reverseConverter in...

Ha...about the VT, it seems that someone added null check in the unconvert() method and broke the special cases we have in the converter... I will see to fix it...

@jonmeredith I just pushed review commits to address your feedback and follow up discussion plus improved the testing. The only current issue I see is with the `fromMap` in the...

@adelapena I addressed your feedback. The new tests pass locally, but I started full CI #1823 https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17737-4.1-sstable_preemptive_open_interval_in_mb

CI shows some issue with @Nullable, I think I need to change the scope in build.xml for the annotation, I will work it now. I will let you know when...

com.google.code.findbugs needs to have default compile and not provided scope for this patch to work. Looking into its license https://opensource.org/licenses/BSD-3-Clause and reading here - https://www.apache.org/legal/resolved.html I think this is fine....

32bits JDK versions added to the test image

I believe this is the right CI link: https://app.circleci.com/pipelines/github/bereng/cassandra/1175/workflows/c10ae06a-6d8f-4cfa-8738-46f2534df952 Still green though :-)

I almost forgot, we need similar changes for tools/bin/cassandra.in.sh

`I can let it open for now and see if I can find a solution.` Until then, I agree we can add a note in the README to prevent further...