cassandra icon indicating copy to clipboard operation
cassandra copied to clipboard

Published 20 hours ago • verified publisher icon apache

Cassandra 19406 5.0

Open bereng opened this issue 1 year ago • 4 comments

Thanks for sending a pull request! Here are some tips if you're new here:

  • Ensure you have added or run the appropriate tests for your PR.
  • Be sure to keep the PR description updated to reflect all changes.
  • Write your PR title to summarize what this PR proposes.
  • If possible, provide a concise example to reproduce the issue for a faster review.
  • Read our contributor guidelines
  • If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:

<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

bereng avatar Feb 21 '24 08:02 bereng

Workflow seems to be correct here

bereng avatar Feb 21 '24 09:02 bereng

Review comments added and new workflow example here

Current tooling doesn't support removal of a workflow so I couldn't remove the 'separate' ones. I cleaned them though.

Apologies I just realized I used the wrong base branch name in this PR.

bereng avatar Feb 23 '24 08:02 bereng

Green CI https://app.circleci.com/pipelines/github/bereng/cassandra/1176/workflows/86564a8e-006a-4b57-9fdb-e43e2ad20666

bereng avatar Feb 27 '24 08:02 bereng

I believe this is the right CI link: https://app.circleci.com/pipelines/github/bereng/cassandra/1175/workflows/c10ae06a-6d8f-4cfa-8738-46f2534df952 Still green though :-)

ekaterinadimitrova2 avatar Feb 27 '24 19:02 ekaterinadimitrova2