cassandra icon indicating copy to clipboard operation
cassandra copied to clipboard

Fix for CASSANDRA-18688: Limit Java runtime in 5.0 to JDK17 in scripts; add a flag to opt out of that

Open shyla226 opened this issue 1 year ago • 3 comments

Limits Cassandra 5.0 startup to JDK11 & JDK17. An option -J has been added to bypass this limit

shyla226 avatar Aug 09 '23 21:08 shyla226

I almost forgot, we need similar changes for tools/bin/cassandra.in.sh

ekaterinadimitrova2 avatar Aug 10 '23 20:08 ekaterinadimitrova2

@shyla226 this is looking good. i have further questions about tightening up the messages, and avoiding us having to edit hardcoded numbers.

these are best expressed in the following suggested patch. does it make sense ? are you willing to squash it into your work ? https://github.com/apache/cassandra/commit/edecd68d277ae0deb645ae160077c3e9341be6ed

(if you agree, it would need to be re-applied to each of the modified files)

michaelsembwever avatar Nov 19 '23 06:11 michaelsembwever

Plus we need to test the packaging in Jenkins

Jenkins does not work for pre-commit on 5.0 and trunk. Jenkins just uses the in-tree scripts, and it has already been tested thoroughly with these (separately by both @shyla226 and myself)

michaelsembwever avatar Dec 04 '23 21:12 michaelsembwever