Eitan Joffe comments

Results 66 comments of


                                            Eitan Joffe

Amend panics when `true` is not available at `/usr/bin/true`

closing as this hasn't occured in a while.

Pull request template

Looks good to me. Lets give it a try.

Feature Request:

You can now run 'git spr update --no-rebase` or `git spr update -nr`. Also there is a configuration in the user config to disable rebase by default. Thank you @adambenhassen...

git-spr subcomand panics with invalid memory address

@jameskyle - can you please check if you still have this issue in the latest v0.10.0?

Can't rebase onto latest

Can you give more details? `git spr update` will rebase your current stack on top of origin/main

Reverse direction of `--count` in `git spr update`, have >1 commits per level in the stacked PR

1. When you run `spr update` all the commits in the stack get updated and pull requests created. The idea of --count is in the case that you are currently...

Reverse direction of `--count` in `git spr update`, have >1 commits per level in the stacked PR

There is now a noRebase configuration in UserConfig to disable rebase on update. Regarding 2: We can add a `--comment` argument to `git amend` which will amend the comment to...

Why does adding a new commit affect PRs on commits earlier in the stack?

Hi Guys, Sorry I haven't had much time recently as have I been really busy with my startup. I have tagged a new release v0.9.3 with the latest master, let...

GITHUB-407: Gracefully handle Cygwin paths on Windows when determining root directory

Sorry about the delay. Looks good to me. One nit: is there a better check to see if it's cygwin instead of checking the HasPrefix equal to cygdrive? this seems...

Reordering commits confuses spr

This sounds like a bug. SPR actually has logic to handle reordering of commits. Everything you did is actually (or should be) a-ok. I will try to recreate this case...