Eitan Joffe

Results 66 comments of Eitan Joffe

What version of spr are you using?

There was a recent bug fix for this released in 0.14.8 on 1/12/2024. If you are running a previous version, this is a known issue. If you are really running...

@chriscz : You are right that spr used to use a commit hook to add the commit-id. This mechanism changed to longer need a commit hook, instead appending the commit-id...

Sorry about the long delay guys. I agree with @chriscz, lets add a configuration knob for this, off by default so we maintain the same logic, and then can also...

Similar change based on this change #440 has been merged.

@WesleyYue - does the pre-commit hook run when you commit the change or when you push the change to origin?

spr doesn't call git commit, so I'm not sure how the extra flag helps?

git spr update calls git push to update the branches on GitHub. But doesn't call git commit, that you have to do on your own before you call git spr...

Can you add more details please. In what cases would you want to skip commit hooks?

Are these custom pre-commit hooks that you have? or the commit msg hook that spr runs while updating the stack?