spr icon indicating copy to clipboard operation
spr copied to clipboard

GITHUB-407: Gracefully handle Cygwin paths on Windows when determining root directory

Open anenviousguest opened this issue 1 year ago • 4 comments

Fixes #407

anenviousguest avatar May 21 '24 13:05 anenviousguest

hi @ejoffe , any chance to get the feedback on this ? thanks.

anenviousguest avatar May 22 '24 22:05 anenviousguest

Sorry about the delay. Looks good to me. One nit: is there a better check to see if it's cygwin instead of checking the HasPrefix equal to cygdrive? this seems fragile.

ejoffe avatar May 30 '24 20:05 ejoffe

Hi @ejoffe

is there a better check to see if it's cygwin instead of checking the HasPrefix equal to cygdrive? this seems fragile.

within shell scripts, the check would typically be based on uname -a command output - but apparently this won't work if spr is running in plain CMD environment. So i didn't want to overcomplicate the implementation which i won't be able to test anyway, because my cygwin paths all start with /cygdrive

anenviousguest avatar May 30 '24 22:05 anenviousguest

@ejoffe any chance to get this merged ? 😅

anenviousguest avatar May 31 '24 07:05 anenviousguest