Eirik Sletteberg
Eirik Sletteberg
> call to the other API using Superagent The problem might be that Superagent isn't instrumented (yet). In order for Zipkin to pick up the trace state from one service...
We could [org-scope](https://docs.npmjs.com/creating-and-publishing-an-org-scoped-package) all the packages, but that's a lot of work, and a very breaking change.
Have you tried using zipkin as a peerDependency instead of a regular dependency?
I don't think it's written anywhere. I remember vaguely that this was the solution to a similar problem I encountered some years ago. Using peerDependency will ensure that all your...
Relevant: https://github.com/testcontainers/testcontainers-node
I suppose zipkin-context-v8 or something like that could be a plugin? Possibly work with a custom build of node.js until it has landed.
I believe promisifying code shouldn't have any effect on zipkin instrumentation at all. Does it stop it from working?
It's correct that Bluebird adds promisified methods `doXxxAsync()` but these methods again call `doXxx()` which is instrumented by zipkin-instrumentation-redis. Isn't that correct? If you use the console tracer, you can...
:-( Just to reproduce, can you add an integration test? Fork this project and add `packages/zipkin-instrumentation-redis/test/bluebird-integrationTest.js` similar to the other example, but where the client is Bluebird-promisified.
I think we should be able to refactor the code base a little bit, so you can pass in a context API as a constructor argument instead of hard-coding to...