Eirik Sletteberg
Eirik Sletteberg
Go ahead, that's a good change, I think! Even better would be if the middleware had access to the server object, with knows which port it is listening on. In...
How will this work on Windows (which doesn't have symlinks, I think)?
:+1: However, this project has an integration test that tries to run pnpm. As far as I can see, that integration test is now passing. Is it possible to create...
@JulesAaelio I merged your PR with the failing integration test. As you can see here: https://github.com/eirslett/frontend-maven-plugin/actions/runs/3169669688/jobs/5161739948 it looks like the integration test is still failing on Ubuntu? Can you have...
:+1: So how do we make the test pass on Windows then?
Ok, let's merge it anyways! And hopefully somebody on Windows will fix it if they need it.
``` $ curl http://registry.npmjs.org/npm/-/npm-v4.0.5.tgz -i HTTP/1.1 500 Internal Server Error Content-Type: application/json Cache-Control: max-age=0 Content-Length: 71 Accept-Ranges: bytes Date: Wed, 11 Jan 2017 12:26:04 GMT Via: 1.1 varnish Connection: keep-alive...
I'm reluctant to add it -there's already a lot of feature bloat in this plugin, there are bugs galore and I'd rather not introduce any new functionality. There were also...
LGTM!
+1 [sw-precache-webpack-plugin](https://github.com/goldhand/sw-precache-webpack-plugin) doesn't work with webpack-dev-server because the dev server holds all assets in memory (fast incremental builds), and that makes much it harder to work with sw-precache + webpack....