Eric Huss

Results 755 comments of Eric Huss

document external cargo subcommand PATH precedence

Updating the documentation sounds good to me!

fix(trim-paths): remap common prefix only

r? @epage

test(priv_dep): add test for `verify public is respected recursively`

r? epage

Always set `MACOSX_DEPLOYMENT_TARGET` in build scripts

Can you say why this would not be handled in rustc? Generally we try to avoid having cargo have explicit target knowledge. Fixing this in rustc is tracked in https://github.com/rust-lang/rust/issues/118204.

Always set `MACOSX_DEPLOYMENT_TARGET` in build scripts

Ah, thanks for the clarification, I misunderstood.

future-incompatibilities should tell you where the dependency comes from

Transferred to rust-lang/cargo. Note that this can be difficult to show in the message, because the inverted dependency tree can be very deep, and have multiple paths through the tree...

"error: path too long" on Windows when doing "cargo install --git"

One thought is to have cargo automatically set that option when creating dependency or index clones. I think that should work, and should be safe, and doesn't appear to require...

cargo: prevent dashes in lib.name

Hm, I didn't think about the consequence of this impacting the artifact-dependency environment variables, which appears to be a breaking change. For example, I did a quick code search and...

cargo: prevent dashes in lib.name

@Eh2406, @Muscraft, @joshtriplett do you think you can check the FCP [above](https://github.com/rust-lang/cargo/pull/12783#issuecomment-1750726185)? Do you have any questions or concerns? Anything that can help you understand this change?

cargo: prevent dashes in lib.name

Thanks! Will merge now that the FCP has passed. @bors r+