Eric Huss

Results 755 comments of Eric Huss

> > Is the `target.runner` case covered as well? Is it possible to test this change with [rust-lang/rust#113730](https://github.com/rust-lang/rust/pull/113730) (after removing the Miri workaround)? > > I believe the answer is...

> Unless I misunderstood the question, doesn't this PR make the `target_process`, either test executable or target runner, inherit jobserver? 🤔 I'm not sure if we are looking at the...

@weihanglo Just checking, are you ok with moving `inherit_jobserver` to `target_process` to also cover runners as mentioned in #12597?

In https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/Stabilizing.20global.20cache.20tracking/near/422500781 I am proposing to stabilizing just the recording of the cache data as a first step. This doesn't enable automatic or manual gc.

r? @weihanglo It looks like you have this covered, but feel free to reassign it back to me if you want.

`CompileMode::Doc` seems like the correct place, especially with output computation and fingerprinting being involved. I would also expect things like `calc_outputs` to get updated.

Which version of `wslview` do you have? You can view it with: `wslview --version`. I can't seem to reproduce it myself, so I suspect that it may be due to...

This would definitely be useful, I have a macro in my editor for repeating a test. Something built-in would be nicer. However, it is not clear exactly how this should...

For the ssh memory credential issue, the build.rs will need to be updated to accommodate https://github.com/libgit2/libgit2/pull/6617. In particular, it looks like GIT_SSH_MEMORY_CREDENTIALS was renamed to GIT_SSH_LIBSSH2_MEMORY_CREDENTIALS. The test is also...