Eric Huss

Results 785 comments of Eric Huss

Can you say more about what you think is wrong? I think the comment is saying you can't destructure with something like `let Vec{ptr, cap, len} = self;` because that...

Oh, good point! I don't know what the comment means then. 🙃

You can use [`RepoBuilder`](https://docs.rs/git2/latest/git2/build/struct.RepoBuilder.html) to control the clone options (`FetchOptions`, `CheckoutBuilder`, etc.). libgit2 does not support shallow clones, though.

That is the documentation available. Is there something that seems to be missing? The [`FetchOptions`](https://docs.rs/git2/latest/git2/struct.FetchOptions.html) and [`CheckoutBuilder`](https://docs.rs/git2/latest/git2/build/struct.CheckoutBuilder.html) contains documentation for each option.

It might be good to list all the concerns that need to be considered for this. For example: * What happens with `--open`? Does that generate an error? * Is...

Thanks for the report! I have moved this to the cargo repo. Unfortunately I'm unable to reproduce with the given instructions. Can you please share a full project that exhibits...

Looking at the attached project, it looks like the dev-dependencies introduce new features in shared dependencies which cause the binary to be rebuilt. That is tracked in #11954. If you...

I believe that is the intended behavior. That is how the `runner` field works for `cargo run`, `cargo test`, and `cargo bench`. You don't have to pass `--target` to have...

@epage Do you want to take on implementation of this, or know someone who will? Or, if not, do you want to write mentoring instructions? I can probably do that...

I believe this was an unintentional regression in 1.15 via #3310. The code has moved around a bit, but it now looks like this: https://github.com/rust-lang/cargo/blob/749654c5fdb26e81f543e76806aedde4327c6cd1/src/cargo/core/compiler/context/mod.rs#L216-L234 The problem is that it...